This repository was archived by the owner on Jul 4, 2025. It is now read-only.
chore: add some unit tests #1158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@namchuai: A few PM requests from me (once you finish your draft)
In the future, I would push for you guys to include unit tests with the issue-closing PR, so it's easier to refer to. But for now, I really appreciate the push to increase test coverage |
namchuai
requested review from
dan-menlo,
louis-jan,
nguyenhoangthuan99 and
vansangpfiev
vansangpfiev
approved these changes
Sep 9, 2024
Contributor
vansangpfiev
left a comment
vansangpfiev
left a comment
There was a problem hiding this comment.
Thank you for adding unit tests
dan-menlo
approved these changes
Sep 9, 2024
Contributor
dan-menlo
left a comment
dan-menlo
left a comment
There was a problem hiding this comment.
Lgtm - thanks for writing tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Screenshot
Fixes Issues
Self Checklist